Revert PR #224 due to issue like #288

[ezimuel]

This PR revert #224 due to issue like #288.

Summary: I tried to solve #35 with #224 but I didn't cover all the use cases, for instance #288. After reading also the php-cvs 46848 and 47302, mentioned in PHP BUG 43130, I decided to revert #224 and mark #35 as won't fix. It's not considered a best practice to use these characters in bind param name.

[weierophinney]

I guess the question I have is: do we want to safeguard against invalid parameter names when using PDO? #224 provided a fix for that, clearly, but as you also note, a number of other bugs indicate that most recommend against using invalid characters in the first place.

Perhaps we could do a check for invalid characters (basically, anything outside the accepted character set) and raise an exception?

[michalbundyra]

@weierophinney

Perhaps we could do a check for invalid characters (basically, anything outside the accepted character set) and raise an exception?

That's actually a good idea.

@ezimuel
I'm not sure if this PR completely reverting #224, I can see here "Files changed 4 (+8 −37)", but in #224 we have "Files changed 6 (+67 −5)"

[ezimuel]

@weierophinney throwing exception is a good idea, I'll work on it.

@webimpress yes, it reverts #224 completely, I checked again. #224 contains multiple changes on the same code base.

[ezimuel]

@weierophinney, @webimpress I added the Exception for invalid param name.

[weierophinney]

Perfect! I'll merge shortly and issue the 2.9.1 release.

[ezimuel]

@weierophinney thanks!