Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Hotfix #355: Named params in subquery - limit and offset #357

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Hotfix #355: Named params in subquery - limit and offset #357

merged 1 commit into from
Feb 20, 2019

Conversation

michalbundyra
Copy link
Member

Set proper names for limit and offset parameters in subquery - add prefix.

Fixes #355

  • Are you fixing a bug?
    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.

/cc @rjd22 @tptrixtop @Ocramius

@michalbundyra
Hotfix #355: Named params in subquery - limit and offset
812517e 
Set proper names for limit and offset parameters in subquery - add prefix.

Fixes #355
@michalbundyra michalbundyra mentioned this pull request Feb 14, 2019
Closed
2 tasks
@ezimuel ezimuel merged commit 812517e into zendframework:master Feb 20, 2019
@michalbundyra michalbundyra deleted the hotfix/355-subselect-limit-offset-named-params branch February 20, 2019 18:32
@Ocramius Ocramius added the bug label Feb 21, 2019
@Ocramius Ocramius added this to the 2.9.4 milestone Feb 21, 2019
@michalbundyra michalbundyra modified the milestones: 2.9.4, 2.10.0 Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ezimuel ezimuel

Labels
bug
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

Regression version 2.9.3: Using limit in subselects with PDO causes bindParameters to fail
3 participants
@michalbundyra @Ocramius @ezimuel