Added stream rewind in JsonResponse constructor

zendframework · Dec 16, 2015 · ffb22ed · ffb22ed
1 parent bbd7ffe
commit ffb22ed
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/Response/JsonResponse.php b/src/Response/JsonResponse.php
@@ -61,6 +61,7 @@ public function __construct(
     ) {
         $body = new Stream('php://temp', 'wb+');
         $body->write($this->jsonEncode($data, $encodingOptions));
+        $body->rewind();
 
         $headers = $this->injectContentType('application/json', $headers);
 

diff --git a/test/Response/JsonResponseTest.php b/test/Response/JsonResponseTest.php
@@ -126,4 +126,13 @@ public function testUsesSaneDefaultJsonEncodingFlags($value, $key)
             sprintf('Did not encode %s properly; expected (%s), received (%s)', $key, $expected, $contents)
         );
     }
+
+    public function testConstructorRewindsBodyStream()
+    {
+        $json = ['test' => 'data'];
+        $response = new JsonResponse($json);
+
+        $actual = json_decode($response->getBody()->getContents(), true);
+        $this->assertEquals($json, $actual);
+    }
 }