This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Verbose exception message from header validators #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,7 +129,7 @@ public static function isValid($value) | |||
| public static function assertValid($value) | |||
| { | |||
| if (! self::isValid($value)) { | |||
| throw new InvalidArgumentException('Invalid header value'); | |||
| throw new InvalidArgumentException("'$value' is not valid header value"); | |||
There was a problem hiding this comment.
We typically use sprintf() for interpolation in exception messages; I'll make that change on merge.
weierophinney
added a commit
that referenced
this pull request
Mar 17, 2016
Verbose exception message from header validators
weierophinney
added a commit
that referenced
this pull request
Mar 17, 2016
weierophinney
added a commit
that referenced
this pull request
Mar 17, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current version of Diactoros I often see exceptions like "Invalid header value". It doesn't show which header is not valid, making it difficult to see what's the problem.
With this PR server logs will clearly show which header caused exception.