-
Notifications
You must be signed in to change notification settings - Fork 152
Used relative stream to simplify emitBodyRange. Removes necessity to check lower bound #202
Used relative stream to simplify emitBodyRange. Removes necessity to check lower bound #202
Conversation
$body->seek($first); | ||
$pos = $first; | ||
$body = new RelativeStream($response->getBody(), $first); | ||
$body->rewind(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This directly conflicts with #200 (represented in lines 84 - 88 above), which provided a fix that ensures that the emitter can be used with non-seekable streams. Please reinstate that block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I saw that. Will find some time to fix that asap.
…check lower bound
1ac7f8b
to
5e38627
Compare
@weierophinney should be fixed now 😉 waiting for the build. |
Looks like the rebase dropped the lines entirely around testing for seekable streams, @hannesvdvreken — please see: https://travis-ci.org/zendframework/zend-diactoros/jobs/158205643#L240-L248 |
@hannesvdvreken I can see how to fix this; I'll take it from here. |
Used relative stream to simplify emitBodyRange. Removes necessity to check lower bound
Thanks, @hannesvdvreken |
I was away from computer for a while. Thanks for finishing this, @weierophinney. |
My pleasure, @hannesvdvreken — thanks for the patch! |
Replaces #188