This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Add missing HTTP status codes/messages #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
inoas
approved these changes
Sep 27, 2016
inoas
suggested changes
Sep 27, 2016
| @@ -81,8 +83,10 @@ class Response implements ResponseInterface | |||
| 428 => 'Precondition Required', | |||
There was a problem hiding this comment.
421 Misdirected Request is still missing.
Ref: https://httpstatuses.com/421
Ref: https://github.com/cakephp/cakephp/pull/9530/files#diff-a57bc7407c64664db661cb46c465f363R81
|
Would you consider changing |
weierophinney
added a commit
that referenced
this pull request
Oct 11, 2016
Add missing HTTP status codes/messages
weierophinney
added a commit
that referenced
this pull request
Oct 11, 2016
weierophinney
added a commit
that referenced
this pull request
Oct 11, 2016
weierophinney
added a commit
that referenced
this pull request
Oct 11, 2016
Forward port #208 Conflicts: CHANGELOG.md
weierophinney
added a commit
that referenced
this pull request
Oct 11, 2016
`ResponseTest::testReasonPhraseCanBeEmpty()` was using status 599 as, prior to #208, no default reason phrase was provided in `Response` for that code. Now that there is, we need to use a different one. Updated to 555, as it is not currently reserved.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At cakephp/cakephp#9516, we were discussing missing status codes in CakePHP's and Zend's libraries.
This brings both (almost) in sync by adding missing status codes & messages.
Used https://httpstatuses.com/ as reference.