This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Hotfix for #102 BC break validationGroup ignored for collections #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n' into hotfix/issue-102-BC-break-because-of-collections-fix
svycka
changed the title
|
@weierophinney is this BC break? maybe I didn't cover everything? you can close this if you think this is not a good fix :D or suggest how to fix it. |
|
👍 |
weierophinney
added a commit
that referenced
this pull request
Sep 14, 2016
…-of-collections-fix Hotfix for #102 BC break validationGroup ignored for collections
weierophinney
added a commit
that referenced
this pull request
Sep 14, 2016
weierophinney
added a commit
that referenced
this pull request
Sep 14, 2016
svycka
deleted the
hotfix/issue-102-BC-break-because-of-collections-fix
branch
rwrz
reviewed
Sep 20, 2016
There was a problem hiding this comment.
-
if ($validationGroup && (array_key_exists($name, $validationGroup) || !in_array($name, $validationGroup))) {
This piece of CODE is wrong! Should be
if ($validationGroup && (!array_key_exists($name, $validationGroup) && !in_array($name, $validationGroup))) {
Please, fix it!
|
@rwrz can you raise a PR with a test case and the fix? |
rwrz
pushed a commit
to rwrz/zend-form
that referenced
this pull request
Sep 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a hack but don't know how we could fix it without BC.