This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Add InputFilterFactory dependency to constructor #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The factory currently only had a setInputFilterFactory() method and no way to set it during construction, this change makes the dependency obvious.
|
add test please |
|
I've added test and fixed code style issues. |
froschdesign
approved these changes
Jan 12, 2017
akrabat
added a commit
that referenced
this pull request
Feb 23, 2017
Add InputFilterFactory dependency to constructor
akrabat
added a commit
that referenced
this pull request
Feb 23, 2017
|
Merged to develop in b990f9f |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The factory currently only had a setInputFilterFactory() method and no way to set it during construction, this change makes the dependency obvious.
This was causing me problems using custom validators until @DASPRiD pointed me towards the method call.