Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Fixes order in which default initializers are injected #119

Merged
merged 7 commits into from
Sep 14, 2016

Commits on Sep 13, 2016

  1. Configuration menu
    Copy the full SHA
    a9724df View commit details
    Browse the repository at this point in the history
  2. Merge pull request zendframework#117 from Slamdunk/testcase/issue-100

    Reproduce issue zendframework#100 without mvc and modulemanager dependencies
    weierophinney committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    707f6a6 View commit details
    Browse the repository at this point in the history
  3. Fixes order in which default initializers are injected

    Uses the test from zendframework#117 to find a solution for zendframework#100 by overriding `configure()`
    to first remove the default initializers from the initializer stack if present,
    and then push them on in the appropriate positions once configuration is
    complete.
    weierophinney committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    81c5d3f View commit details
    Browse the repository at this point in the history
  4. Incorporated feedback

    - Ensure consistent license on new files, with correct year
    - `s/Dependancy/Dependency/g`
    - Added dockblocks on new class methods and properties
    weierophinney committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    83ab4fe View commit details
    Browse the repository at this point in the history
  5. Refactor tests

    Removes need for additional test asset classes by using mock objects to
    test behavior of initializers.
    
    Adds a test to verify that the plugin manager injected into a form's
    factory is the application form element manager.
    weierophinney committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    0365eab View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2016

  1. Ensure injectFactory is called before callElementInit in all versions

    Adds a unit test to ensure that the `injectFactory()` initializer is
    injected prior to the `callElementInit()` initializer, and updates the
    V2 polyfill to ensure the behavior is correct.
    
    A new test asset was created to help spy on behavior.
    weierophinney committed Sep 14, 2016
    Configuration menu
    Copy the full SHA
    6e7d469 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b839697 View commit details
    Browse the repository at this point in the history