This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
set correct Factory when autoAddInvokableClass=true #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain what problem this fixes? |
|
When you get element with options : this is wrong |
froschdesign
previously requested changes
Mar 15, 2017
| @@ -0,0 +1,25 @@ | |||
| <?php | |||
| /** | |||
| * Zend Framework (http://framework.zend.com/) | |||
There was a problem hiding this comment.
Please update the license header and use:
/**
* @see https://github.com/zendframework/zend-navigation for the canonical source repository
* @copyright Copyright (c) 2017 Zend Technologies USA Inc. (http://www.zend.com)
* @license https://github.com/zendframework/zend-form/blob/master/LICENSE.md New BSD License
*/|
|
||
| if (! $this->has($name)) { | ||
| if (! $this->autoAddInvokableClass || ! class_exists($name)) { | ||
| throw new Exception\ServiceNotFoundException(sprintf( |
There was a problem hiding this comment.
ServiceNotFoundException is not imported.
test/FormElementManagerTest.php
Outdated
| @@ -222,6 +222,13 @@ public function testAddingInvokableCreatesAliasAndMapsClassToElementFactory() | |||
| } | |||
| } | |||
|
|
|||
| public function testAutoAddInvokableClass() | |||
| { | |||
| $instance = $this->manager->get(TestAsset\ConstructedElement::class, ['constructedKey' => 'constructedKey']); | |||
There was a problem hiding this comment.
Please reduce the line length to 80.
|
|
||
| class ConstructedElement extends Element | ||
| { | ||
| public $constructedKey = null; |
| { | ||
| public $constructedKey = null; | ||
|
|
||
| public function __construct($name = null, $options = array()) |
There was a problem hiding this comment.
Add a type hint for $options.
|
@froschdesign Your requested changes have been applied |
weierophinney
dismissed
froschdesign’s stale review
Author has made the requested changes.
weierophinney
added a commit
that referenced
this pull request
Apr 26, 2017
weierophinney
added a commit
that referenced
this pull request
Apr 26, 2017
Forward port #134 Conflicts: CHANGELOG.md
|
Thanks, @turrsis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set correct
Zend\Form\ElementFactory(instead ofZend\ServiceManager\Factory\InvokableFactory) whenFormElementManager::autoAddInvokableClass = true.fix for #114