This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Fix how inputs for elements nested in collections are merged #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwillbanks
suggested changes
Apr 26, 2017
As reported in zendframework#78, if you compose an input filter provider fieldset as a target element of a collection in order to allow providing a default fieldset for the collection, input provider elements composed by the input filter provider fieldset were not being merged correctly into the input filter. This patch checks to see if the fieldset's input filter represents a collection, and, if so, will check its own composed input filter for the element and merge it if found.
weierophinney
force-pushed
the
hotfix/78
branch
from
010d007 to
2a0dfe5
Compare
mwillbanks
approved these changes
Apr 26, 2017
weierophinney
added a commit
that referenced
this pull request
Apr 26, 2017
weierophinney
added a commit
that referenced
this pull request
Apr 26, 2017
Forward port #156 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #78, if you compose an input filter provider fieldset as a target element of a collection in order to allow providing a default fieldset for the collection, input provider elements composed by the input filter provider fieldset were not being merged correctly into the input filter.
This patch checks to see if the fieldset's input filter represents a collection, and, if so, will check its own composed input filter for the element and merge it if found.