This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Fixed the "__clone method called on non-object" error that happens when the targetElement is null. #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Feb 21, 2019
|
@Ocramius Hey! Could I ask for a re-review? I've added the missing regression test. Thanks in advance. |
Ocramius
suggested changes
Feb 21, 2019
|
@Ocramius Requests resolved. :) |
weierophinney
added a commit
that referenced
this pull request
Feb 26, 2019
Expands the description to make it more clear that this affects `Collection` instances only, and what the new behavior is.
weierophinney
added a commit
that referenced
this pull request
Feb 26, 2019
weierophinney
added a commit
that referenced
this pull request
Feb 26, 2019
Forward port #230 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting the
__clone method called on non-objecterror while populating data in the fieldset and there was no targetElement available (it was null).I think such a fix should not create regressions in the software since when targetElement is null it errors anyway.
I'll provide the changelog entry and regression text in later commits (since it seems like I need an issue number for the fix which I'm going to get after submitting this pull request).