Inject input filter factory when creating new input filter

[ffraenz]

Custom validators and filters are not available in forms pulled from the FormElementManager. I already discussed this issue here.

When the object bound to the form does not implement InputFilterAwareInterface, the form creates its InputFilter instance itself when getInputFilter gets called:

$this->filter = new InputFilter();

In this case, the Zend\InputFilter\Factory dependency of this newly created input filter instance does not get satisfied which results in creating a different factory instance with separate ServiceManagers lazily.

The form has a pointer to a Zend\InputFilter\Factory instance with properly injected ServiceManagers. Adding following line right after the statement shown above makes custom filters and validators available inside the form as expected:

$this->filter->setFactory($this->getFormFactory()->getInputFilterFactory());

Both getFormFactory and getInputFilterFactory create instances lazily if they have not been injected. This statement should never fail.

[Maks3w]

Need tests

[ffraenz]

I test if getInputFilter creates a new input filter having the same factory instance injected as set in the form's factory. This is true when the factory instances are lazily created and when they are injected by service managers.

[Maks3w]

Factory should be set too after the inputfilter created on line 681

[ffraenz]

That should do.

[ffraenz]

Do you consider merging? Is there anything else you need?

[weierophinney]

Sorry for the delay reviewing and merging, @ffraenz - merged now, and will be released in a 2.7.1 version soon.