This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Issue 37 add aria tags #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
@esr360 |
|
@froschdesign not a php developer so I asked my friend for help with this. If there are any issues with the tests we have written would be great if you could be as specific as possible as to how they can be improved, we will happily make the changes. |
weierophinney
added a commit
that referenced
this pull request
Apr 7, 2016
weierophinney
added a commit
that referenced
this pull request
Apr 7, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request addresses issue number 37 in the zend-form component repo, and adds all 'aria-*' attributes to the whitelist and removing the previously hard coded 'aria-labelledby' and 'aria-describedby' attributes.