This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Expose as a config provider / component #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imports the `FormElementManagerFactory` from zend-mvc, and provides tests.
Ports a test from the zend-mvc test suite to ensure behavior of the form element manager.
…ctory. Imported `Zend\Mvc\Service\FormAnnotationBuilderFactory` as the class `Zend\Form\Annotation\AnnotationBuilderFactory`, and imported the tests as well. Tests were re-written to better cover the class, and the class was refactored using extract method refactoring.
Adds: - `ConfigProvider`, which maps the `FormElementsManager` and `FormAnnotationBuilder` servies previously provided by zend-mvc; the form abstract factory as previously registered by zend-mvc; and all view helper configuration. - `Module`, which maps services and view helpers per the `ConfigProvider`, and provides configuration to the zend-modulemanager `ServiceLocator` in order for modules to provide form and form element configuration. Updates `Zend\Form\View\HelperConfig` to consume the `ConfigProvider` in order to provide view helper factories and aliases.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
FormElementManagerFactory, originally from zend-mvc, along with tests.Zend\Form\Annotation\AnnotationBuilderFactory, originally from zend-mvc (asZend\Mvc\Service\FormAnnotationBuilderFactory), along with tests.ConfigProvider, which maps theFormElementsManagerandFormAnnotationBuilderservies previously provided by zend-mvc; the form abstract factory as previously registered by zend-mvc; and all view helper configuration.Module, which maps services and view helpers per theConfigProvider, and provides configuration to the zend-modulemanagerServiceLocatorin order for modules to provide form and form element configuration.Finally , it also updates
Zend\Form\View\HelperConfigto consume theConfigProviderin order to provide view helper factories and aliases, and marks the class as deprecated.