Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Missing input types search and tel #57

Closed

Conversation

MidnightDesign
Copy link
Contributor

No description provided.

'required' => true,
'filters' => [
['name' => StringTrim::class],
['name' => StripNewlines::class],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this in place, your RegexValidator is essentially moot...

Copy link
Contributor Author

@MidnightDesign MidnightDesign Apr 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it? What if someone removes this filter? They probably still want the validation to work..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they set their own input filter, they won't get that validator anyways...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I mean if they change the filters on the input filter.

@weierophinney weierophinney added this to the 2.9.0 milestone Apr 28, 2016
@weierophinney weierophinney self-assigned this Apr 28, 2016
* Zend Framework (http://framework.zend.com/)
*
* @link http://github.com/zendframework/zf2 for the canonical source repository
* @copyright Copyright (c) 2005-2015 Zend Technologies USA Inc. (http://www.zend.com)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2016

weierophinney added a commit that referenced this pull request Jun 7, 2016
weierophinney added a commit that referenced this pull request Jun 7, 2016
weierophinney added a commit that referenced this pull request Jun 7, 2016
@weierophinney
Copy link
Member

Merged to develop for release with 2.9.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants