Ensure that the default initializers register last #65
Conversation
Per zendframework#58 and zendframework#64, 2.7.0 introduced a regression due to the fact that the default initializers, `injectFactory()` and `callElementInit()`, were registered *prior* to delegating to the parent constructor instead of *afterwards*. This led to problems when the order of initializers was important (e.g., if an initializer was practicing setter injection, and the injected instance was expected when `init()` was called by `callElementInit()`). This patch provides a test that asserts the expected behavior, and updates the `FormElementManager` constructor to properly inject the initializers after calling the parent constructor.
Will simplify testing both locally and on Travis CI.
It can be safely replaced with the composer autoloader; right now, it prevents testing against the lowest allowed dependencies.
- Need PHPUnit 4.8+ for prophecy.
|
After seeing the failing tests (all against v2 of zend-servicemanager), I did some digging. Interestingly, in the v2 releases, Prior to v2.7, $this->addInitializer([$this, 'injectFactory']);
$this->addInitializer([$this, 'callElementInit'], false);In other words, it pushes the Updating the patch now to reflect this. |
While initializer order should not be depended on, `FormElementManager` *does*, as `init()` needs to be fired at the very last, and the form factor needs to injected at the very beginning. This patch ensures that behavior across both v2 and v3 versions of zend-servicemanager.
Cache the vendor directory between runs; speeds up installs.
| - CS_CHECK=true | ||
| - php: 5.5 | ||
| env: | ||
| - DEPS=latest |
There was a problem hiding this comment.
Switched to a lowest/locked/latest strategy, as it makes it far easier both on Travis and locally to switch between supported versions in order to test. (Which was critical for this patch, as I needed to verify behavior between zend-servicemanager major versions.)
When xdebug is enabled, tests are consistently taking greater than 10 minutes on that job, causing travis to suspend the job.
Per #58 and #64, 2.7.0 introduced a regression due to the fact that the default initializers,
injectFactory()andcallElementInit(), were registered prior to delegating to the parent constructor instead of afterwards. This led to problems when the order of initializers was important (e.g., if an initializer was practicing setter injection, and the injected instance was expected wheninit()was called bycallElementInit()).This patch provides a test that asserts the expected behavior, and updates the
FormElementManagerconstructor to properly inject the initializers after calling the parent constructor.