Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

fix tests for recent ICU version #91

Merged
merged 1 commit into from
Apr 25, 2018
Merged

fix tests for recent ICU version #91

merged 1 commit into from
Apr 25, 2018

Conversation

remicollet
Copy link
Contributor

Fix #14

And new issue with ICU 60, from Fedora QA
https://apps.fedoraproject.org/koschei/package/php-zendframework-zend-i18n

There was 1 failure:
1) ZendTest\I18n\Validator\IsFloatTest::testValidationFailures with data set #11 ('10,1', false, 'fr-CH')
Failed expecting 10,1 being false (locale:fr-CH)
Failed asserting that true matches expected false.
/builddir/build/BUILD/zend-i18n-d3431e29cc00c2a1c6704e601d4371dbf24f6a31/test/Validator/IsFloatTest.php:159

@weierophinney weierophinney merged commit 48c6362 into zendframework:master Apr 25, 2018
weierophinney added a commit that referenced this pull request Apr 25, 2018
@weierophinney
Merge pull request #91 from remicollet/issue-icu
9f192b6 
fix tests for recent ICU version
weierophinney added a commit that referenced this pull request Apr 25, 2018
@weierophinney
Adds CHANGELOG entries for #78 and #91.
e094f24
weierophinney added a commit that referenced this pull request Apr 25, 2018
@weierophinney
Merge branch 'hotfix/78' into develop
070d4de 
Forward port #78
Forward port #91

Conflicts:
	CHANGELOG.md
weierophinney added a commit that referenced this pull request Apr 25, 2018
@weierophinney
Merge branch 'hotfix/78'
b3c92d7 
Close #78
Close #91
@weierophinney
Copy link
Member

Thanks, @remicollet!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remicollet @weierophinney