This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Add getCacheId() and clearCache() method to Translator #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malukenho
suggested changes
Apr 27, 2018
src/Translator/Translator.php
Outdated
| * Get the cache identifier for a specific textDomain and locale. | ||
| * | ||
| * @param string $textDomain | ||
| * @param string $locale |
src/Translator/Translator.php
Outdated
| * Clears the cache for a specific textDomain and locale. | ||
| * | ||
| * @param $textDomain | ||
| * @param $locale |
|
Fixed the comments and added tests. Is there any consensus in the ZF code style about using static methods via |
For unit tests, that's the style we've consistently done since, well, we began. There's an open discussion in our forums covering exactly this, though with no consensus as of yet. |
weierophinney
added a commit
that referenced
this pull request
May 16, 2018
Add getCacheId() and clearCache() method to Translator
weierophinney
added a commit
that referenced
this pull request
May 16, 2018
weierophinney
added a commit
that referenced
this pull request
May 16, 2018
|
Thanks, @MatthiasKuehneEllerhold. Merged to develop for release with 2.9.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #63 for discussion.