Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Set the plugin manager #96

Merged
merged 3 commits into from
May 16, 2018
Merged

Set the plugin manager #96

merged 3 commits into from
May 16, 2018

Conversation

MatthiasKuehneEllerhold
Copy link
Contributor

@weierophinney weierophinney merged commit b0ba39d into zendframework:master May 16, 2018
weierophinney added a commit that referenced this pull request May 16, 2018
weierophinney added a commit that referenced this pull request May 16, 2018
@weierophinney
Copy link
Member

Thanks, @MatthiasKuehneEllerhold!

@MatthiasKuehneEllerhold
Copy link
Contributor Author

Thanks for merging, but I deliberatly had no check if TranslatorPluginManager in the factory because it is defined by the same module. Is there a situation where not all dependencies from the ConfigProvider are used?

@weierophinney
Copy link
Member

Is there a situation where not all dependencies from the ConfigProvider are used?

Yes: if somebody is not using the ConfigProvider and/or Module. Having the check is a safe-guard, and we typically add these when a dependency is optional. (If it's non-optional, calling get() is sufficient, as an exception will be thrown if the service is not present.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants