This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Updated ModuleManager to EventManager v3 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Principal issues:
- Aggregate listeners needed to define the `$priority = 1` argument in
`attach()`.
- `attachAggregate()` calls needed to be updated to instead use
`$aggregate->attach()`.
- `trigger()` statements needed updating. In most cases, we were using actual
event instances, which meant:
- Updating the code to add the event name just before triggering.
- Updating the trigger statements to either `triggerEvent()` or
`triggerEventUntil()`.
- Triggers with callbacks needed the new argument order.
- `EventManager` instances during testing needed to be injected with the
`SharedEventManager` instance during instantiation. Any that set identifiers
during instantiation needed to change argument order.
Extracted common methods for introspecting event manager listeners to a new trait, EventManagerIntrospectionTrait, and updated all test cases that consumed one or more of them to use the trait instead.
weierophinney
added a commit
that referenced
this pull request
Sep 30, 2015
Also updated branch alias, as this targets 3.0 (which the CHANGELOG notes)
weierophinney
added a commit
that referenced
this pull request
Sep 30, 2015
weierophinney
added a commit
that referenced
this pull request
Feb 25, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Principal issues:
$priority = 1argument inattach().attachAggregate()calls needed to be updated to instead use$aggregate->attach().trigger()statements needed updating. In most cases, we were using actual event instances, which meant:triggerEvent()ortriggerEventUntil().EventManagerinstances during testing needed to be injected with theSharedEventManagerinstance during instantiation. Any that set identifiers during instantiation needed to change argument order.