Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Resolve modules using PHP 5.5 ::class #5

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Listener/ModuleResolverListener.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ class ModuleResolverListener extends AbstractListener
public function __invoke(ModuleEvent $e)
{
$moduleName = $e->getModuleName();
if (class_exists($moduleName)) {
return new $moduleName;
}

$class = $moduleName . '\Module';

if (!class_exists($class)) {
Expand Down
26 changes: 23 additions & 3 deletions test/Listener/ModuleResolverListenerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

namespace ZendTest\ModuleManager\Listener;

use ListenerTestModule;
use PHPUnit_Framework_TestCase as TestCase;
use Zend\Loader\AutoloaderFactory;
use Zend\Loader\ModuleAutoloader;
Expand Down Expand Up @@ -54,13 +55,32 @@ public function tearDown()
set_include_path($this->includePath);
}

public function testModuleResolverListenerCanResolveModuleClasses()
/**
* @dataProvider validModuleNameProvider
*/
public function testModuleResolverListenerCanResolveModuleClasses($moduleName, $expectedInstanceOf)
{
$moduleResolver = new ModuleResolverListener;
$e = new ModuleEvent;

$e->setModuleName('ListenerTestModule');
$this->assertInstanceOf('ListenerTestModule\Module', $moduleResolver($e));
$e->setModuleName($moduleName);
$this->assertInstanceOf($expectedInstanceOf, $moduleResolver($e));
}

public function validModuleNameProvider()
{
return [
// Description => [module name, expectedInstanceOf]
'Append Module' => ['ListenerTestModule', ListenerTestModule\Module::class],
'FQCN Module' => [ListenerTestModule\Module::class, ListenerTestModule\Module::class],
'FQCN Arbitrary' => [ListenerTestModule\FooModule::class, ListenerTestModule\FooModule::class],
];
}

public function testModuleResolverListenerReturnFalseIfCannotResolveModuleClasses()
{
$moduleResolver = new ModuleResolverListener;
$e = new ModuleEvent;

$e->setModuleName('DoesNotExist');
$this->assertFalse($moduleResolver($e));
Expand Down
7 changes: 7 additions & 0 deletions test/TestAsset/ListenerTestModule/FooModule.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<?php

namespace ListenerTestModule;

class FooModule
{
}