fix proto and enable php 7.1 in travis #55

remicollet · 2017-02-22T07:05:26Z

PHPUnit 5.7.13 by Sebastian Bergmann and contributors.
.................................WWW.......PHP Fatal error:  Declaration of ZendTest\ModuleManager\Listener\TestAsset\SampleAbstractFactory::__invoke(Interop\Container\ContainerInterface $container, $name, array $options = Array) must be compatible with Zend\ServiceManager\Factory\FactoryInterface::__invoke(Interop\Container\ContainerInterface $container, $requestedName, ?array $options = NULL) in /builddir/build

samsonasik · 2017-02-22T07:22:41Z

test/Listener/TestAsset/SampleAbstractFactory.php

@@ -26,7 +26,7 @@ public function canCreateServiceWithName(ServiceLocatorInterface $container, $na
        return true;
    }

-    public function __invoke(ContainerInterface $container, $name, array $options = [])
+    public function __invoke(ContainerInterface $container, $name, array $options = NULL)


small null instead of NULL imo for consistency

Forward port #55

samsonasik reviewed Feb 22, 2017

View reviewed changes

fix proto and enable php 7.1 in travis

870e1c4

remicollet force-pushed the issue-proto branch from 2ab82ce to 870e1c4 Compare February 22, 2017 07:24

Xerkus merged commit 22cdfa5 into zendframework:master Mar 12, 2017

Xerkus added a commit that referenced this pull request Mar 12, 2017

Merge branch 'hotfix/55' into develop

54769f5

Forward port #55

remicollet deleted the issue-proto branch March 12, 2017 08:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix proto and enable php 7.1 in travis #55

fix proto and enable php 7.1 in travis #55

remicollet commented Feb 22, 2017

samsonasik Feb 22, 2017

remicollet Feb 22, 2017

fix proto and enable php 7.1 in travis #55

fix proto and enable php 7.1 in travis #55

Conversation

remicollet commented Feb 22, 2017

samsonasik Feb 22, 2017

Choose a reason for hiding this comment

remicollet Feb 22, 2017

Choose a reason for hiding this comment