Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

use default console exception template instead of empty string #5

Merged
merged 1 commit into from
Apr 7, 2016
Merged

use default console exception template instead of empty string #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Service/ConsoleExceptionStrategyFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ private function injectDisplayExceptions(ExceptionStrategy $strategy, array $con
*/
private function injectExceptionMessage(ExceptionStrategy $strategy, array $config)
{
$message = isset($config['exception_message']) ? $config['exception_message'] : '';
$strategy->setMessage($message);
if (isset($config['exception_message'])) {
$strategy->setMessage($config['exception_message']);
}
}
}
5 changes: 3 additions & 2 deletions test/Service/ConsoleExceptionStrategyFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,14 @@ public function testEnablesDisplayExceptionsWithoutConfiguration()
$this->assertTrue($strategy->displayExceptions());
}

public function testProvidesEmptyExceptionMessageWithoutConfiguration()
public function testProvidesDefaultExceptionMessageWithoutConfiguration()
{
$this->container->has('config')->willReturn(false);

$strategy = $this->factory->__invoke($this->container->reveal(), ExceptionStrategy::class);
$this->assertInstanceOf(ExceptionStrategy::class, $strategy);
$this->assertEquals('', $strategy->getMessage());
$plainStrategy = new ExceptionStrategy();
$this->assertEquals($plainStrategy->getMessage(), $strategy->getMessage());
}

public function overrideDisplayExceptionsConfiguration()
Expand Down