This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Remove i18n-related functionality and unnecessary dependencies #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the various i18n-related classes in favor of a suggestion to use zend-mvc-i18n. In removing those classes, also audited `composer.json` and removed any dependencies and/or suggestions that were no longer relevant.
Current test failures are due to sebastian/version not reporting the correct version when the lowest stable version is installed (1.0.4 of that package corrected the issue). Since `test/bootstrap.php` was essentially unrequired at this point, removing it in favor of using only the composer autoloader simplifies dependencies while retaining the testing strategy.
weierophinney
added a commit
that referenced
this pull request
Mar 30, 2016
weierophinney
added a commit
that referenced
this pull request
Mar 30, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the various i18n-related classes in favor of a suggestion to use zend-mvc-i18n. In removing those classes, also audited
composer.jsonand removed any dependencies and/or suggestions that were no longer relevant.