This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Set required components for version 3 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://github.com/zendframework/maintainers/wiki/zend-mvc-v3-refactor:-reduce-components#required-components : - Sets the required components to include: - zend-eventmanager - zend-servicemanager - zend-view - zend-http - zend-modulemanager - zend-stdlib - Removes: - zend-json; this is a purely optional component at this point, even in terms of testing. - Marks as development requirement: - zend-psr7bridge (only needed if you're using the `MiddlewareListener`) Finally, this patch inlines the logic of `Zend\Filter\Word\CamelCaseToDash` in the `InjectTemplateListener` so as to remove any requirement on zend-filter (though it's still a dev requirement until we remove the factory related to it.)
`$inflector` is no longer used since inlining the logic.
weierophinney
added a commit
that referenced
this pull request
Apr 5, 2016
weierophinney
added a commit
that referenced
this pull request
Apr 5, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://github.com/zendframework/maintainers/wiki/zend-mvc-v3-refactor:-reduce-components#required-components :
in terms of testing.
MiddlewareListener)Finally, this patch inlines the logic of
Zend\Filter\Word\CamelCaseToDashin theInjectTemplateListenerso as to remove any requirement on zend-filter (though it's still a dev requirement until we remove the factory related to it.)