This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Remove support for servicemanager and eventmanager v2 #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... and also zend-eventmanager v2. |
snapshotpl
changed the title
Xerkus
suggested changes
Mar 10, 2017
| { | ||
| $r = new ReflectionClass(ServiceLocatorInterface::class); | ||
| if ($r->hasMethod('build')) { | ||
| $this->injectV3Aliases(); |
There was a problem hiding this comment.
breaking change, high chance someone still uses those compatibility aliases
There was a problem hiding this comment.
@Xerkus you have right. That's why I add aliases into $defaultServiceConfig property (above)
| * | ||
| * @return void | ||
| */ | ||
| private function injectV3Aliases() |
There was a problem hiding this comment.
breaking change, high chance someone still uses those compatibility aliases
Xerkus
approved these changes
Mar 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zend-servicemanager v2 support is dropped in v3 so we can remove tone of code...