This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Ensure that we replace zendframework/zend-router due to class confl…
#233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icts `zendframework/zend-mvc` in version less than 3.0 is still replacing `zendframework/zend-router` due to incompatible exception changes. Therefore we should tell projects that this package is replacing `zendframework/zend-router`. The downsides are the mentioned exception incompatibilities but even if a user is requiring `zendframework/zend-router` in version 2 and using this package as well, he wont get the expected exceptions since `zendframework/zend-mvc` is being used instead of `zendframework/zend-router`.
weierophinney
added a commit
that referenced
this pull request
Apr 27, 2017
Ensure that we replace `zendframework/zend-router` due to class confl… Conflicts: composer.lock
weierophinney
added a commit
that referenced
this pull request
Apr 27, 2017
weierophinney
added a commit
that referenced
this pull request
Apr 27, 2017
|
Thanks, @boesing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…icts
zendframework/zend-mvcin version less than 3.0 is still replacingzendframework/zend-routerdue to incompatible exception changes. Therefore we should tell projects that this package is replacingzendframework/zend-router.The downsides are the mentioned exception incompatibilities but even if a user is requiring
zendframework/zend-routerin version 2 and using this package as well, he wont get the expected exceptions sincezendframework/zend-mvcis being used instead ofzendframework/zend-router.