Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Url factory does not work starting in 2.6 #71

Merged
merged 3 commits into from
Feb 22, 2016
Merged

Url factory does not work starting in 2.6 #71

merged 3 commits into from
Feb 22, 2016

Commits on Feb 22, 2016

  1. Ensure that helpers with override factories work for all aliases 

    This patch implements tests for each of the url, basepath, and doctype
helpers, ensuring that the factory is invoked and the helper returned
properly configured *for each alias* we define, as well as for the fully
qualifed class name.

Interestingly, while the basepath and doctype tests fail for every case,
the URL helper only fails for the case of a fully qualified name; I'm
hoping this will still work as a fix.

I've refactored the `ViewHelperManagerFactory` substantially using the
extract method refactor to extract:

- helper factories (these are returned by dedicated methods now)
- helper factory registration
- helper configuration from other components

In the case of the second bullet point, I am now registering the plugins
using the FQCN as well as the normalized version of it, and not the
aliases; the aliases will resolve to the factory name.
    @weierophinney
    weierophinney committed Feb 22, 2016
    Configuration menu
    Copy the full SHA
    3739645 View commit details
    Browse the repository at this point in the history

  2. Fix failing hydrator test 

    - normalize "config" service to lower case.
    @weierophinney
    weierophinney committed Feb 22, 2016
    Configuration menu
    Copy the full SHA
    91f292c View commit details
    Browse the repository at this point in the history

  3. Also test normalized full class names

    @weierophinney
    weierophinney committed Feb 22, 2016
    Configuration menu
    Copy the full SHA
    facef82 View commit details
    Browse the repository at this point in the history