This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Continue fixing service casing issues #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes zendframework#78 : using uppercase for 'Application' service
- Because we register services under both the names 'application' and 'Application' normally, we need to do both in tests as well. - The various factories in ViewHelperManagerFactory were incorrect; `$services` as passed to each is guaranteed to be the application service manager instance, so the conditionals that were pulling the parent were unnecessary.
Updated the `ServiceListenerFactory` to conditionally add either Titlecase or lowercase aliases under zend-servicemanager v3 for common one-word factories (currently config, request, response, router, and application). This avoids the circular alias issue under v2 (where the normalized factory name ensures all cases match), while simultaneously ensuring common usage scenarios continue to work (fetching by alternate case).
weierophinney
added a commit
that referenced
this pull request
Feb 29, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch builds on #80 and takes a different approach: conditionally declaring aliases when under zend-servicemanager v3.
This approach: