This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Ensure listener detachment works cross-version #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if a returned callback is a CallbackHandler, and, if so, pull the actual PHP callable from it before testing for the class. To ensure both BC and forwards compatibility, ensure that the priority is stored when detaching, so that re-attaching will continue to work. In order to use `composer update --prefer-lowest`, I had to: - update PHPUnit to `^4.5`, as that's the first version using prophecy, which we're using in tests now. - add sebastian/version:^1.0.4, as that's the first version that fixes version autodiscovery, ensuring that the test runner knows we're on a version later than 2.5.
|
Forgot to note that this addresses #90. |
weierophinney
added a commit
that referenced
this pull request
Mar 8, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if a returned callback is a CallbackHandler, and, if so, pull the actual PHP callable from it before testing for the class. To ensure both BC and forwards compatibility, ensure that the priority is stored when detaching, so that re-attaching will continue to work.
In order to use
composer update --prefer-lowest(which I did for testing against zend-eventmanager v2), I had to:^4.5, as that's the first version using prophecy, which we're using in tests now.Tests for this are ridiculously hard to write; would love some review!