This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Consume zend-router and remove internal Router subcomponent #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labeling as a WIP, as I plan to get this working with zend-router v3. |
This patch updates the component to use zend-router 3.0, allowing the removal of the entire `Zend\Mvc\Router` namespace, as well as related factories in the `Zend\Mvc\Service` namespace. Tests were updated to reflect the change. One set of tests, for the url controller plugin, were marked skipped, as they rely on zend-view being updated to use zend-router. TODO ---- - [ ] once zend-view is updated, update the dependencies in this patch. - [ ] experiment with having tests use zend-router as a module/config provider, to see if they can pass.
weierophinney
force-pushed
the
feature/zend-router
branch
from
deb0e74 to
3651cb4
Compare
This patch updates the `ServiceListener` to remove all router entries, in favor of consuming zend-router as a module/configuration provider. For tests to pass, this required changes to test setup entries to do one of the following: - add the `Zend\Router` module to the list of active modules, relying on the `ModuleManager` to aggregate and configure its factories. - pull dependency configuration from the zend-router `ConfigProvider` when setting up initial dependencies for minimal tests that do not use the `ModuleManager` for application initialization.
zend-mvc-console now provides all console-related integration between zend-mvc, zend-router, and zend-view, allowing it to be removed from this component. Doing this as part of the zend-router removal, as otherwise you cannot actually route to console-related controllers.
Broken against zend-servicemanager v2, as it was using constant notation instead of a string when invoking itself.
weierophinney
added a commit
that referenced
this pull request
Mar 24, 2016
weierophinney
added a commit
that referenced
this pull request
Mar 24, 2016
weierophinney
added a commit
that referenced
this pull request
Mar 24, 2016
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that zend-router has been split out, we can remove it from the zend-mvc distribution, and add zend-router as a dependency.
Changes required:
Zend\Mvc\Routersubcomponent and related tests.Zend\Mvc\Servicefactories that are now in zend-router.Routerentries in theServiceListenerto refer to the factories from zend-router.Routerfactory that simply returns theHttpRouterservice.TODO
ConsoleRouter, as this will be optional functionality provided by zend-mvc-console, and will not need to be mapped in theServiceListener.[ ] zend-view needs to be updated to consume zend-router; as such we'll need to update this PR again in the future to reference the new zend-view version once it's tagged.This can and should be merged before zend-view is updated; we'll just need to update once zend-view is updated.Modulefor providing service mappings, to see if it can be consumed seamlessly that way.