This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Fixes paginator cache, problem with the generation of cacheInternalId #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 25, 2017 11:05
…nerate the Internal Id. This fix also fixes a future problem with complex Adapters that cannot be serizable.
…on those cases as well.
|
@weierophinney I have fixed this cache problem, but Travis isn't working because there is a problem with a Trait in ServiceManager... and a problem with HHVM on unserialize function, but those problems aren't related to this fix. I tried to figure it out the HHVM problem, but couldn't. |
This was referenced Jun 3, 2017
|
Having the same problem! @rwrz still working on this? |
|
@rwrz The build failures are due to an issue with the upstream zend-servicemanager library when using the latest version (essentially, a trait used in testing within this library is provided by that component, but it uses a newer PHPUnit version). I'll try and address that, and then merge this patch. |
weierophinney
added a commit
that referenced
this pull request
Nov 1, 2017
Fixes paginator cache, problem with the generation of cacheInternalId Conflicts: src/Paginator.php
weierophinney
added a commit
that referenced
this pull request
Nov 1, 2017
|
Thanks, @rwrz! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix also fixes a future problem with complex Adapters that cannot be serializable.
fixes #1 , joined the #24 and part of #30 , and included tests for both.
Also, improved the method to get cacheInternalId to accept inherited adapter as well, without considering those the same adapters.