Allows the use of ArrayObject config service with ConfigAbstractFactory #174
Conversation
|
With Expressive skeleton, "config" service is an ArrayObject https://github.com/zendframework/zend-expressive-skeleton/blob/master/config/config.php |
|
The ArrayObject is caused by using the zend-expressive-skeleton to setup the application. It is only there for the Aura.Di and is fixed and removed in the develop branch. You can easily replace that last line in config/config.php with If this causes issues in a zend-expressive-skeleton based application, I think it should be reported to zend-expressive-skeleton. So far no issues have been reported. It would be interesting to know what steps you took during installation in order to get that error. |
|
Yes, but i think it may be good to have this compatibility with ArrayObject. |
| @@ -40,8 +41,8 @@ public function __invoke(\Interop\Container\ContainerInterface $container, $requ | |||
|
|
|||
| $config = $container->get('config'); | |||
|
|
|||
| if (! is_array($config)) { | |||
| throw new ServiceNotCreatedException('Config must be an array'); | |||
| if (! is_array($config) and (! is_object($config) or ! $config instanceof \ArrayObject)) { | |||
There was a problem hiding this comment.
Change this line to:
if (! (is_array($config) || $config instanceof ArrayObject)) {| ] | ||
| ]) | ||
| ); | ||
| self::assertTrue($abstractFactory->canCreate($serviceManager, InvokableObject::class)); |
There was a problem hiding this comment.
Remove this. This particular test case is covering the values related to configured classes. You have a more specific test for the ArrayObject behavior below which this is duplicating anyways.
| @@ -76,6 +88,23 @@ public function testCanCreate() | |||
| self::assertFalse($abstractFactory->canCreate($serviceManager, ServiceManager::class)); | |||
| } | |||
|
|
|||
| public function testCanCreateWithArrayObject() | |||
There was a problem hiding this comment.
Rename this to testCanCreateReturnsTrueWhenConfigIsAnArrayObject.
There was a problem hiding this comment.
Also, add an additional test testFactoryCanCreateInstancesWhenConfigIsAnArrayObject, demonstrating that the factory correctly creates the instance when the config service is an ArrayObject.
bfolliot
force-pushed
the
ConfigAbstractFactory_options-from-array-object
branch
from
41ee165 to
7efae58
Compare
|
@weierophinney : It's good for you now? |
…rom-array-object Allows the use of ArrayObject config service with ConfigAbstractFactory
No description provided.