This repository has been archived by the owner on Feb 6, 2020. It is now read-only.
Add PSR-11 support to ServiceManager
#180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates `ServiceLocatorInterface` to implement **both** the psr/container and container-interop `ContainerInterface` implementations. Could not modify it to _only_ implement the psr/container interface, as that does not fulfill the type necessary for the various factories.
|
How we should deal with \Interop\Container\ContainerInterface in implements of the following factories interface like Factory, InvokableFactory, etc? |
|
@byan Read the proposed psr-11.md file and changelog - I cover the topic in those. |
Also, updated the container-interop-implementation constraint to `^1.2`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the
container-interop/container-interopconstraint to^1.2, and explicitly addspsr/containerwith a constraint of^1.0; this immediately allowsZend\ServiceManager\ServiceManagerto be used as a PSR-11 container.Moreover, this patch provides a test validating that assertion.