Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Hotfix for issue "Commands out of sync" on Mysqli adapter #120

Merged
merged 16 commits into from
Aug 11, 2019
Merged

Hotfix for issue "Commands out of sync" on Mysqli adapter #120

merged 16 commits into from
Aug 11, 2019

Conversation

michalbundyra
Copy link
Member

@michalbundyra michalbundyra commented Aug 11, 2019 •
edited
Loading

Follow up to PR #116 and #109

The problem "Commands out of sync; you can't run this command now" is observed only while using mysqli adapter. That's why test from #109 pass also without changes in code as in tests we are using only PDO_Sqlite.

In this PR I am adding tests with different adapters - PDO_Sqlite, PDO_Mysql, Mysqli and Pgsql.

  • Are you fixing a bug?
    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.

@michalbundyra michalbundyra self-assigned this Aug 11, 2019
@michalbundyra michalbundyra added this to the 2.8.6 milestone Aug 11, 2019
@michalbundyra
Merge pull request #116 from cabasatech/bug-commandsoutofsync
e786736 
Close #116

Fixed "Commands out of sync; you can't run this command now"
@michalbundyra
Merge pull request #109 from sawarame/lifetime-exceed
d380dd1 
Close #109

Fix for an error if save handler use mysql and destroy expired session.
@michalbundyra
Remve backticks in queries as not all database uses the same quotes f…
67c2e70 
…or fields
@michalbundyra
Refactor read to have more consistent code
d2dcbbf 
Removed assignment from if statement and removed magic null statement.
The issue presented in tests is still fixed with these changes.
@michalbundyra michalbundyra changed the title Hotfix for issue "Command out of sync" Hotfix for issue "Commands out of sync" on Mysqli adapter Aug 11, 2019
michalbundyra added a commit that referenced this pull request Aug 11, 2019
@michalbundyra
Merge pull request #120 from webimpress/hotfix/commands-out-of-sync
01b106c 
Hotfix for issue "Commands out of sync" on Mysqli adapter
michalbundyra added a commit that referenced this pull request Aug 11, 2019
@michalbundyra
Merge branch 'hotfix/120' into develop
b17bfa3 
Forward port #120

# Conflicts:
#	CHANGELOG.md
@michalbundyra michalbundyra merged commit 75b277e into zendframework:master Aug 11, 2019
michalbundyra added a commit that referenced this pull request Aug 11, 2019
@michalbundyra
Merge branch 'hotfix/120'
723d219 
Close #120
Close #116
Close #109
@michalbundyra michalbundyra deleted the hotfix/commands-out-of-sync branch August 11, 2019 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@michalbundyra michalbundyra

Labels
bug
Projects
None yet
Milestone
2.8.6
Development

Successfully merging this pull request may close these issues.
3 participants
@michalbundyra @sawarame @malkesh