This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Develop.validate session #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You will need to provide unit tests to cover the changes you are proposing to this component. Your fix extends the public API of SessionManager (by adding a new constructor argument) and adds a new class so it will need closer scrutiny before a decision can be made. |
|
Ok, I'll add tests asap. |
| * Zend Framework (http://framework.zend.com/) | ||
| * | ||
| * @link http://github.com/zendframework/zf2 for the canonical source repository | ||
| * @copyright Copyright (c) 2005-2015 Zend Technologies USA Inc. (http://www.zend.com) |
|
Needs #28 to avoid tests fall. |
| * @param array $options | ||
| * @return SessionManager | ||
| */ | ||
| public function setOptions(array $options) |
There was a problem hiding this comment.
The point of your pull request is to allow having default validators enabled, not to expose arbitrary options. As such, I plan to remove the setOptions/getOptions methods on merge, as they are not part of that goal, and because the side-effects of options passed to the constructor can be determined programmatically already.
weierophinney
added a commit
that referenced
this pull request
Apr 11, 2016
- Removed `set`/`getOptions()`, as they were unnecessary to the pull request, and unwanted items to the public API. - Do not store options; unneeded after instantiation. - Merge default validators before passing to parent constructor. - Use `::class` notation wherever possible. - Store session id as `$id` property in `Id` validator; naming is now consistent with purpose. - Provide the delimiters to regex patterns when defining them; prevents need for concatenation later. - Provide guaranteed invalid identifier value when testing ID validator. - Updated SessionManagerFactory to allow detecting and utilizing options when creating SessionManager instance.
weierophinney
added a commit
that referenced
this pull request
Apr 11, 2016
|
Merged to develop for release with 2.7.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #21 fix. Now if session id invalid, the exception
Exception\RuntimeException('Session validation failed')will thrown.