This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Forwards compatibility with zend-servicemanager, zend-eventmanager v3 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated to stable, forwards-compatible versoins of all dependencies. - Updated test matrix to test against both v2 and v3 of event/service manager implementations.
- Updates all factories and abstract factories to re-introduce v2 compatibility.
- Removed extra constructor arguments from ValidatorChain; no longer necessary, and removing them helps retain BC. - Use `triggerEventUntil()` instead of `triggerUntil()` (latter has FC problems).
- Use ServiceManager\Config instances and/or the various setters to configure service managers. - Use `::class` notation wherever possible. - Refactor tests for listeners to work with both EM versions.
Since the definitions for EventManager::attach differ between major versions, we have to introduce a polyfill to alias version-specific implementations to the ValidatorChain class.
weierophinney
force-pushed
the
feature/forwards-compat
branch
from
7a063f2
to
707a7d9
Compare
weierophinney
added a commit
that referenced
this pull request
Feb 23, 2016
weierophinney
added a commit
that referenced
this pull request
Feb 23, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the code base forwards compatible with zend-servicemanager and zend-eventmanager v3. Changes include:
triggerUntilto instead usetriggerEventUntil().