This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Fix issue with iterative removal #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In testing zend-eventmanager, I discovered a race condition with the
following:
```php
while ($queue->contains($listener)) {
$queue->remove($listener);
}
```
In debugging, I determined that while `remove()` was correctly
identifying that it had the datum, it was not using the correct index in
the value array to unset it, which would leave it in place. Modifying
the code to use `key()` on the values array allows it to work as
expected.
weierophinney
added a commit
that referenced
this pull request
Sep 25, 2015
weierophinney
added a commit
that referenced
this pull request
Sep 25, 2015
weierophinney
added a commit
that referenced
this pull request
Sep 25, 2015
weierophinney
deleted the
hotfix/remove-with-multiple-items-in-queue
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing zend-eventmanager, I discovered a race condition with the following:
In debugging, I determined that while
remove()was correctly identifying that it had the datum, it was not using the correct index in the value array to unset it, which would leave it in place. Modifying the code to usekey()on the values array allows it to work as expected.