3.2.0 readiness

zendframework · Apr 7, 2018 · 6266064 · 6266064
2 parents c9d0a21 + b01ef3a
commit 6266064
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,12 +2,14 @@
 
 All notable changes to this project will be documented in this file, in reverse chronological order by release.
 
-## 3.1.2 - TBD
+## 3.2.0 - 2018-04-07
 
 ### Added
 
 - [#60](https://github.com/zendframework/zend-test/pull/60) Added support for
   PHPUnit 7
+- [#65](https://github.com/zendframework/zend-test/pull/65) Added support for
+  query parameters in DELETE request in AbstractControllerTestCase
 
 ### Deprecated
 

diff --git a/src/PHPUnit/Controller/AbstractControllerTestCase.php b/src/PHPUnit/Controller/AbstractControllerTestCase.php
@@ -254,6 +254,7 @@ public function url($url, $method = HttpRequest::METHOD_GET, $params = [])
                     $post = $params;
                     break;
                 case HttpRequest::METHOD_GET:
+                case HttpRequest::METHOD_DELETE:
                     $query = array_merge($query, $params);
                     break;
                 case HttpRequest::METHOD_PUT:

diff --git a/test/PHPUnit/Controller/AbstractControllerTestCaseTest.php b/test/PHPUnit/Controller/AbstractControllerTestCaseTest.php
@@ -492,6 +492,7 @@ public function method()
     {
         yield 'null' => [null];
         yield 'get' => ['GET'];
+        yield 'delete' => ['DELETE'];
         yield 'post' => ['POST'];
         yield 'put' => ['PUT'];
         yield 'patch' => ['PATCH'];
@@ -507,4 +508,10 @@ public function testDispatchWithNullParams($method)
         $this->dispatch('/custom-response', $method, null);
         $this->assertResponseStatusCode(999);
     }
+
+    public function testQueryParamsDelete()
+    {
+        $this->dispatch('/tests', 'DELETE', ['foo' => 'bar']);
+        $this->assertEquals('foo=bar', $this->getRequest()->getQuery()->toString());
+    }
 }