This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Allow sebastian/version 2.0 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no API change in V2, only a raise of the PHP minimal version to 5.6
|
The only reason for explicitly indicating the sebastian/version dependency is due to the way the test bootstrap works. We could likely solve this by requiring a minimum PHPUnit version of 4.8 instead. Can you give that a try, and run |
|
--prefer-lowest pull PHPUnit 4.8 and version 1.0.0 This version of PHPUnit (release-2.6.1-7-g93608c3) is not supported in the zend-test unit tests. Supported is version 4.0.0 or higher. See also the CONTRIBUTING.md file in the component root. So keeping min version for sebastian/version is still needed Tests ok with phpunit 4.8.0 + version 1.0.4 |
weierophinney
added a commit
that referenced
this pull request
Sep 6, 2016
Allow sebastian/version 2.0
weierophinney
added a commit
that referenced
this pull request
Sep 6, 2016
weierophinney
added a commit
that referenced
this pull request
Sep 6, 2016
|
Thanks, @remicollet |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no API change in V2, only a raise of the PHP minimal version to 5.6