-
Notifications
You must be signed in to change notification settings - Fork 38
Provide PHPUnit class aliases to other projects implementing zend-test
#49
Provide PHPUnit class aliases to other projects implementing zend-test
#49
Conversation
This is something that should be proposed to PHPUnit upstream, or else it
forces more maintenance burden on any library relying on it.
…On 21 May 2017 14:56, "Max" ***@***.***> wrote:
Since the file autoload/phpunit-class-aliases.php is stored within
autoload-dev, no remote project will ever get those aliases which will
cause to problems if they're using PHPUnit in versions less than 6.0.
We should provide those aliases to them from within autoload so there is
no need in remote projects to manually add those aliases themselves or by
using a creepy composer configuration like:
"autoload-dev": { "files": [ "vendor/zendframework/zend-test/autoload/phpunit-class-aliases.php" ]}
------------------------------
You can view, comment on, or merge this pull request online at:
#49
Commit Summary
- Provide PHPUnit class aliases to other projects implementing
`zend-test`
File Changes
- *M* composer.json
<https://github.com/zendframework/zend-test/pull/49/files#diff-0> (10)
Patch Links:
- https://github.com/zendframework/zend-test/pull/49.patch
- https://github.com/zendframework/zend-test/pull/49.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#49>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakArjNYJ7LCzXsxkvMJtp4RD1zhelks5r8DSNgaJpZM4Nhl3i>
.
|
…ng autoloading configuration
a5566db
to
66eb00d
Compare
@Ocramius Maybe, but this library is allowing PHPUnit less than 6. I dont think that PHPUnit should handle this. PHPUnit is not responsible for libraries which allow multiple, BC broken major versions. This library whether should change its dependencies to a version which does not need those aliases or it has to provide proper autoloading which can be used in all projects relying on this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've used composer update nothing
for this one.
To anyone needing this change, you can install it here:
|
@dillchuk thats definitely a useful package but I am still thinking that this package might provide those aliases since it provides testing abilities to other projects. |
Merging it because aliases are required for zend-test itself to work with older phpunit, not for tests using zend-test |
Since the file
autoload/phpunit-class-aliases.php
is stored withinautoload-dev
, no remote project will ever get those aliases which will cause to problems if they're using PHPUnit in versions less than6.0
.We should provide those aliases to them from within
autoload
so there is no need in remote projects to manually add those aliases themselves or by using a creepy composer configuration like: