Enable/Disable Player Aging #18

gtabot · 2021-03-17T16:06:22Z

Added a new parameter which enables/disables aging
It will hide/display several aging lines on the player depending on the player's age

gtabot · 2021-03-17T16:06:54Z

This branch is built on top of the previous Editor branch and reflects the new editor changes

dumbmatter · 2021-03-18T01:40:38Z

^ branch switching was to get GitHub to update the diff in this PR after I merged the other PR, crazy that is still necessary!

dumbmatter

Thank you! This looks like it's on the right path, I just have a few ideas...

dumbmatter · 2021-03-18T02:32:34Z

src/display.ts

@@ -98,11 +98,30 @@ type FeatureInfo = {
 };

 const drawFeature = (svg: SVGSVGElement, face: Face, info: FeatureInfo) => {
-  const feature = face[info.name];
+  const feature = Object.assign({}, face[info.name]);


Why this change? I think it doesn't do anything, but I may be missing something.

This change creates a copy of face[info.name] instead of passing the reference, this way face doesn't get changed even if the actual features drawn vary. The reason why I'm doing this will make sense after reading below.

My thinking and overall strategy for implementing the aging feature was that the parts and their values would act as master DNA for the person if aging.enabled = true. Another way to think of this is you are supplying what features the person can and will ultimately get as he ages. So for example, if the generated face has forehead lines, those lines won't be drawn until the person is in his older 30s. This way, the same JSON face object can go through the aging progression simply by incrementing the age value, rather than having to keep track of adding and subtracting parts.

The problem with that is you'd then have to generate every new face with a bunch of wrinkles and other old people features. Otherwise you'd have some that never age.

Ultimately you can get the same result either way, I just think it'd be more intuitive to have the base face object be the young version, and then add on stuff to represent aging. Because that's what actually happens as real humans age :)

I guess I'm more considering generating new faces rather than aging existing faces. I figured new face objects would have to be generated anyway to include the aging key/values.

However, I think by making the base face object the young version, it won't allow users to specify what aging lines will eventually occur when the face ages. Or if the deterministic aging isn't varied enough, you might see too many common combinations of heads/lines. I'd rather have the option to choose what my face will look like at 35 and then have the younger versions of the face be determined, especially since its basically just removal of lines. I do realize that's now how it works in real life but I believe this way allows for full customization, i.e. what if I want a different aging line for a face then what the deterministic random would apply.

Another way of phrasing that is... you pick all the facial features you want for your guy. Some will appear/disappear based on age. If you say he has a bunch of wrinkles, he won't when he's young. If you say he has long hair, he might not when he's old. I think that makes enough sense for people to understand.

dumbmatter · 2021-03-18T02:38:30Z

src/display.ts

+    face.aging &&
+    face.aging.enabled &&
+    info.name === "hair" &&
+    feature.id === "short-bald" &&


This handles one hair style, but not any of the others. Maybe in generate.ts, short-bald and bald should never be selected, and then here they can be activated at some age cutoff for other hair styles.

Fun way of doing that and having it feel random - somehow pick a deterministic random number seeded with some of the info in the face object. Use that to determine the age balding starts (short-bald) and ends (bald).

I like this idea. I'll make this change in the next commit!

dumbmatter · 2021-03-18T02:44:02Z

src/display.ts

@@ -311,6 +331,28 @@ const display = (
  ];

  for (const info of featureInfos) {
+    if (face.aging && face.aging.enabled) {


Similar to what I wrote about hair... maybe switch this around, so some facial lines are just never (or more rarely) included in the base face object, and then apply them here (maybe again with deterministic randomness). I think that would make it easier to have aging appear in all faces. Since currently, when I'm playing around with this, a lot of faces are not impacted by aging.

Responding to the last part of your comment. My understanding is that you implemented this version in BBGM and you didn't see many aged faces? If so, first, were you able to inject the age value in aging.age?

If so, my thoughts are the way aging is currently set up (to use the parts as master DNA) a lot of your currently generated face models would not show the effects of aging. This is because I assume the proportion of faces that have aging lines are low combined with the fact that of these faces, only some are actually old enough to show effects of aging. Using this version of faces.js, most if not all generated faces should be randomly assigned aging lines (unless they're blessed with great genes) and those lines would appear appropriately as they age.

Also, I very arbitrarily chose different ages for different lines to appear. They could easily be too high. There could also be a variable called maturity that can span +/- 3 or something which can add an element of variation across the players on when they reach these arbitrary age thresholds.

My understanding is that you implemented this version in BBGM and you didn't see many aged faces?

No, just playing around in the editor UI. But it's the same thing, BBGM generates random faces the same way the editor does.

Also, I very arbitrarily chose different ages for different lines to appear. They could easily be too high. There could also be a variable called maturity that can span +/- 3 or something which can add an element of variation across the players on when they reach these arbitrary age thresholds.

Probably a good idea. On second thought, what I wrote before about using deterministic random numbers to determine aging might be kind of annoying, because then users wouldn't be able to control it...

lol complicated stuff the more you think about it!

…d and selects aging lines

…bled

gtabot · 2021-03-22T01:57:59Z

I made some changes that better respect the aging.enabled parameter. When aging is enabled, aging lines are guaranteed to be selected when generate() is called. Also, aging is enabled by default.

gtabot · 2021-03-22T01:58:24Z

Next, I will see what I can do about balding

gtabot · 2021-03-25T00:01:49Z

Try checking out this version of the branch. What I like to do is click randomize in the editor then click on age and go all the way up/down with the arrow buttons to see that player's aging process.

dumbmatter · 2021-03-30T04:31:21Z

public/editor.html

+                    </div>
+                    <div class="col-5 form-group">
+                      <input
+                        type="number"


Change this to type="range" and you get a nifty slider. Should display the age as text next to it too.

dumbmatter · 2021-03-30T04:33:11Z

public/editor.html

+                  </div>
+                  <div class="row">
+                    <div class="col-5">
+                      <label for="aging-maturity">Maturity</label>


I like having a "maturity" variable but I think it needs to be renamed, at least in the UI, to help people understand what it does. Maybe rename to "Aging speed" or something?

dumbmatter · 2021-03-30T04:45:35Z

Overall this works pretty well! Fun stuff. I will probably merge it, maybe play around with it a bit, and release it... hopefully this week.

@TravisJB89 @domini7 just tagging you in case you guys want to take a look at this branch. Any feedback is welcome!

gtabot · 2021-03-31T01:47:24Z

Awesome! @dumbmatter feel free to make those changes (or any other)

gtabot added 3 commits March 17, 2021 07:37

added aging to editor

340730f

modified age input min/max/step

2288557

implemented aging

22ee228

gtabot mentioned this pull request Mar 17, 2021

Aging #3

Open

gtabot added 4 commits March 17, 2021 09:27

added lines for backwards compatability (no aging key)

a83c3a3

added shave to aging process

2dd6e5f

added shave to aging process

d891d7d

refactored svg folder to svgs in process-svgs.js

a23084f

dumbmatter changed the base branch from master to foo March 18, 2021 01:39

dumbmatter changed the base branch from foo to master March 18, 2021 01:39

dumbmatter requested changes Mar 18, 2021

View reviewed changes

gtabot added 3 commits March 21, 2021 18:12

must specify aging enabled/disabled; generate() respects aging.enable…

a6e335e

…d and selects aging lines

implemented maturity; require age lines to not be none when aging ena…

298895e

…bled

aging enabled by default if not specified

851aedd

now aging hairstyles

c397351

gtabot added 2 commits March 24, 2021 17:15

removed long hair as player ages

7105496

changed range for maturity to [-2, 2]

6f5a62b

dumbmatter reviewed Mar 30, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable/Disable Player Aging #18

Enable/Disable Player Aging #18

gtabot commented Mar 17, 2021

gtabot commented Mar 17, 2021

dumbmatter commented Mar 18, 2021

dumbmatter left a comment

dumbmatter Mar 18, 2021

gtabot Mar 19, 2021

dumbmatter Mar 20, 2021

gtabot Mar 22, 2021

dumbmatter Mar 30, 2021

dumbmatter Mar 18, 2021

gtabot Mar 19, 2021

dumbmatter Mar 18, 2021

gtabot Mar 19, 2021 •

edited

Loading

gtabot Mar 19, 2021

dumbmatter Mar 20, 2021

gtabot commented Mar 22, 2021

gtabot commented Mar 22, 2021

gtabot commented Mar 25, 2021

dumbmatter Mar 30, 2021

dumbmatter Mar 30, 2021

dumbmatter commented Mar 30, 2021

gtabot commented Mar 31, 2021

Enable/Disable Player Aging #18

Are you sure you want to change the base?

Enable/Disable Player Aging #18

Conversation

gtabot commented Mar 17, 2021

gtabot commented Mar 17, 2021

dumbmatter commented Mar 18, 2021

dumbmatter left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gtabot Mar 19, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gtabot commented Mar 22, 2021

gtabot commented Mar 22, 2021

gtabot commented Mar 25, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dumbmatter commented Mar 30, 2021

gtabot commented Mar 31, 2021

gtabot Mar 19, 2021 •

edited

Loading