Skip to content

Commit

Permalink
Merge branch 'feature/skypilot-one-vm-run-orchestrator' of github.com…
Browse files Browse the repository at this point in the history
…:zenml-io/zenml into feature/skypilot-one-vm-run-orchestrator
  • Loading branch information
safoinme committed Jan 15, 2024
2 parents 541ba0f + c295ac2 commit 446c3e5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ zenml integration install sklearn -y
In this case, ZenML has an integration with `sklearn` so you can use the ZenML CLI to install the right version directly.

{% hint style="info" %}
The `zenml integration install sklearn` command is simply doing a `pip install sklearn<1.3` behind the scenes. If something goes wrong, one can always use `zenml integration requirements sklearn` to see which requirements are compatible and install using pip (or any other tool) directly.
The `zenml integration install sklearn` command is simply doing a `pip install sklearn>1.3` behind the scenes. If something goes wrong, one can always use `zenml integration requirements sklearn` to see which requirements are compatible and install using pip (or any other tool) directly.
{% endhint %}

### Define a data loader with multiple outputs
Expand Down
2 changes: 1 addition & 1 deletion src/zenml/integrations/sklearn/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class SklearnIntegration(Integration):
"""Definition of sklearn integration for ZenML."""

NAME = SKLEARN
REQUIREMENTS = ["scikit-learn<1.3"]
REQUIREMENTS = ["scikit-learn>1.3"]

@classmethod
def activate(cls) -> None:
Expand Down
8 changes: 3 additions & 5 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from uuid import uuid4

import pytest
from py._builtin import execfile
from pytest import File
from pytest_mock import MockerFixture

from tests.harness.environment import TestEnvironment
Expand Down Expand Up @@ -325,9 +325,7 @@ def virtualenv(
"tests"
)

execfile(
str(activate_this_file), dict(__file__=str(activate_this_file))
)
File(str(activate_this_file), dict(__file__=str(activate_this_file)))

# Set new system executable
sys.executable = tmp_path / env_bin_dir / "python"
Expand All @@ -346,7 +344,7 @@ def virtualenv(
"your virtual environment to run integration "
"tests"
)
execfile(str(activate_this_f), dict(__file__=str(activate_this_f)))
File(str(activate_this_f), dict(__file__=str(activate_this_f)))

else:
yield ""
Expand Down

0 comments on commit 446c3e5

Please sign in to comment.