Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template not updating due to git diff misuse #1844

Merged
merged 7 commits into from
Sep 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/update-e2e-template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
- name: Check for changes
id: check_changes
run: |
if git diff --quiet "${{ github.event.pull_request.head.ref }}" "origin/${{ github.event.pull_request.head.ref }}"; then
if git diff --quiet "origin/${{ github.event.pull_request.head.ref }}"; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is the main change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and should be the only one. I opened this one but forgot to mention that it is not review-ready, I just needed CIs to run for validation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ready 👍🏼

echo "No active Git changes found."
echo "changes=false" >> $GITHUB_OUTPUT
else
Expand Down
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ celerybeat.pid

# Environments
.env
.venv
.venv*
env/
venv/
ENV/
Expand Down Expand Up @@ -195,3 +195,5 @@ zenml_tutorial/

# script for testing
mlstacks_reset.sh

.local/
6 changes: 2 additions & 4 deletions examples/e2e/Makefile
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@

stack_name ?= e2e_template_stack
setup:
pip install -r requirements.txt
zenml integration install sklearn mlflow s3 kubernetes kubeflow slack evidently -y

install-stack:
@echo "Specify stack name: " && read stack_name && \
@echo "Specify stack name [$(stack_name)]: " && read input && [ -n "$$input" ] && stack_name="$$input" || stack_name="$(stack_name)" && \
zenml experiment-tracker register -f mlflow mlflow_local_$${stack_name} && \
zenml model-registry register -f mlflow mlflow_local_$${stack_name} && \
zenml model-deployer register -f mlflow mlflow_local_$${stack_name} && \
Expand All @@ -14,5 +14,3 @@ install-stack:
evidently_$${stack_name} $${stack_name} && \
zenml stack set $${stack_name} && \
zenml stack up


2 changes: 2 additions & 0 deletions examples/e2e/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ python3 -m venv .venv
source .venv/bin/activate
# Install requirements & integrations
make setup
# Optionally, provision default local stack
make install-stack
# Start the ZenML UI locally (recommended, but optional);
# the default username is "admin" with an empty password
zenml up
Expand Down
Loading