-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Control Plane] parallel running versions support #1859
Merged
avishniakov
merged 37 commits into
feature/OSS-2300-model-watch-tower-v0.1
from
feature/OSS-2478-parallel-running-versions-support
Oct 10, 2023
Merged
Changes from 34 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
50bc06a
linkage of pipeline runs
avishniakov 0ebf539
add docstring
avishniakov 14f1172
Merge branch 'feature/OSS-2300-model-watch-tower-v0.1' into feature/O…
avishniakov 7e5e1fc
Merge branch 'feature/OSS-2300-model-watch-tower-v0.1' into feature/O…
avishniakov 9947808
tricky bug
avishniakov c82878c
full linkage on consumption
avishniakov 86bdf05
lint
avishniakov ba01176
Merge branch 'feature/OSS-2300-model-watch-tower-v0.1' into feature/O…
avishniakov f8dc84b
use client
avishniakov 3d0318c
Merge branch 'feature/OSS-2300-model-watch-tower-v0.1' into feature/O…
avishniakov 63e3a1b
Merge branch 'feature/OSS-2300-model-watch-tower-v0.1' into feature/O…
avishniakov 5b9804c
Auto-update of E2E template
actions-user 37dc0cd
update outdated test
avishniakov d04980f
Merge branch 'feature/OSS-2463-add-runs-linkage-to-model-versions' of…
avishniakov 99abf71
create new version if any step touching it is executed and it was req…
avishniakov b7f91b2
refactor `_link_pipeline_run_to_model`
avishniakov e36bd2d
add few more tests
avishniakov c8ca951
Merge branch 'feature/OSS-2300-model-watch-tower-v0.1' into feature/O…
avishniakov 511885c
parallel execution of model versions
avishniakov 74addcf
add version number
avishniakov 2f164e8
Merge branch 'feature/OSS-2300-model-watch-tower-v0.1' into feature/O…
avishniakov 4b6bb7a
improve readability
avishniakov 7d18a05
protect from misuse
avishniakov 88c2952
extend `ArtifactConfig.model_version`
avishniakov af1d741
align model config docstrings
avishniakov 12b38be
stabilize parallelized test
avishniakov 1998d85
rework test as subprocess calls
avishniakov 2e23ffd
skip subprocess test on windows
avishniakov 20dc2ce
Merge branch 'feature/OSS-2300-model-watch-tower-v0.1' into feature/O…
avishniakov 3d059f7
Merge branch 'feature/OSS-2300-model-watch-tower-v0.1' into feature/O…
avishniakov 3295ac2
after merge mess
avishniakov 8b6c50c
update tests flow based on develop
avishniakov 8e549eb
proper handle __latest__ mv in REST
avishniakov 95dc017
fix get model version endpoint
avishniakov fca8789
Merge branch 'feature/OSS-2300-model-watch-tower-v0.1' into feature/O…
avishniakov b2c715f
simplify user-facing interface
avishniakov 532192d
fix test annotation
avishniakov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully understand why this is needed. Feels like
model_version_name
is the model version andmodel_version_number
is the version of the model version. If that's correct then I think this needs to be redesigned since multi-layered versioning is too confusing in my opinionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This supports what @stefannica asked for.
Model Version is a container entity, which is represented by a display name (
model_version_name
) and continuous number (model_version_number
). A display name is what the user can control, while a number is an auto-incremental integer assigned to it during creation. This change gives the user the flexibility to fetch the model version either by display name or by number.These two are split into separate args, cause I thought it might be too confusing to understand why a "1" would be fetched by name, while 1 would be fetched by number while keeping it mixed in all internal methods.