Add extra config to Kaniko docs
#2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strickvl
requested changes
Nov 3, 2023
| @@ -139,6 +140,7 @@ zenml image-builder register <NAME> \ | |||
| --kubernetes_context=<KUBERNETES_CONTEXT> \ | |||
| --volume_mounts='[{"name": "docker-config", "mountPath": "/kaniko/.docker/"}]' \ | |||
| --volumes='[{"name": "docker-config", "configMap": {"name": "docker-config"}}]' | |||
| # --executor_args='["--compressed-caching=false", "--use-new-run=true"]' | |||
There was a problem hiding this comment.
why has this been commented out?
There was a problem hiding this comment.
It's just there as an illustration?
There was a problem hiding this comment.
Yes exactly because the options are only needed for specific cases
docs/book/stacks-and-components/component-guide/image-builders/kaniko.md
Outdated
Show resolved
Hide resolved
…/kaniko.md Co-authored-by: Alex Strick van Linschoten <strickvl@users.noreply.github.com>
strickvl
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
I implemented/fixed _ to achieve _.
Pre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes