Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly builds #2031

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Nightly builds #2031

merged 6 commits into from
Nov 23, 2023

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented Nov 7, 2023 •
edited
Loading

These changes set up the following:

  • a scheduled run at midnight every night
  • this first runs the unit tests on Ubuntu to prevent pushing something truly broken
  • then it pushes the package as zenml-nightly with the version e.g. 0.46.0-2023-11-07
  • it then pushes all the docker images (server and Python 3.10) with the nightly tag

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@strickvl strickvl added enhancement New feature or request internal To filter out internal PRs and issues labels Nov 7, 2023
avishniakov
avishniakov approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@avishniakov avishniakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll trust it's working 👍🏼

schustmi
schustmi requested changes Nov 7, 2023
View reviewed changes
.github/workflows/publish_to_pypi_nightly.yml Outdated Show resolved Hide resolved
.github/workflows/publish_docker_image_nightly.yml Outdated Show resolved Hide resolved
release-cloudbuild-nightly.yaml Show resolved Hide resolved
schustmi
schustmi requested changes Nov 8, 2023
View reviewed changes
.github/workflows/nightly_build.yml Outdated Show resolved Hide resolved
@strickvl strickvl requested review from schustmi and stefannica and removed request for stefannica November 15, 2023 09:02
stefannica
stefannica approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@stefannica stefannica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We might need to include other python versions when/if people start asking for them.

@strickvl strickvl merged commit c66ddcd into develop Nov 23, 2023
30 of 34 checks passed
@strickvl strickvl deleted the feature/OSS-2595-nightly-builds branch November 23, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avishniakov avishniakov avishniakov approved these changes

@schustmi schustmi schustmi approved these changes

@stefannica stefannica stefannica approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request internal To filter out internal PRs and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@strickvl @stefannica @schustmi @avishniakov