Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depaginate step runs to allow running pipelines with arbitrary step count #2068

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

schustmi
Copy link
Contributor

@schustmi schustmi commented Nov 21, 2023

Describe changes

When resolving step inputs during a pipeline run, we only fetched the first PAGE_SIZE_DEFAULT (set via env variable, defaults to 20) step runs which either

  • led to a failure of the run if the step required an input from a step which was not fetched
  • led to a failure when a non-data upstream step was missing in the list

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Nov 21, 2023
@schustmi schustmi requested review from avishniakov and fa9r November 21, 2023 14:52
@schustmi schustmi merged commit 286eaa9 into develop Nov 22, 2023
30 checks passed
@schustmi schustmi deleted the bugfix/arbitrary-amount-of-steps-in-pipeline branch November 22, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants