Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various bugs #2147

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fix various bugs #2147

merged 1 commit into from
Dec 15, 2023

Conversation

stefannica
Copy link
Contributor

@stefannica stefannica commented Dec 13, 2023

Describe changes

Fix various minor bugs:

  1. Fix random pipeline run name generator to not use spaces (which is a problem with Vertex AI for example
  2. TBC

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table and the corresponding website section.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Dec 13, 2023
Copy link
Contributor

@bcdurak bcdurak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am amazed by the sheer volume of fixes here. It was a challenging review, but I enjoyed it very much. Great changes!

@stefannica stefannica merged commit b56c1e7 into develop Dec 15, 2023
27 of 31 checks passed
@stefannica stefannica deleted the bug/fix-various-bugs branch December 15, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants